-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespaces to JVM metric attributes? #61
Comments
This TC vote has concluded and we should be able to proceed with resolving this issue. I'm in favor of option c because I view it as the least risky. There's no opportunity for future conventions to disagree with the semantics we define for general |
I need to clarify my previous comment. I prefer the names of option c, but with fully qualified names rather than relying on any inheritance from the metric name's namespace:
I also like option b, but don't want to get blocked on a discussion on whether the java memory, gc, thread, and buffer concepts are language agnostic. |
Replaces open-telemetry/opentelemetry-specification#3417
There are (currently) three proposals being discussed for metric attribute namespaces in #51.
This purpose of this issue is to try to arrive at consensus for future JVM metric attribute renames based on each of these three proposals.
Today:
process.runtime.jvm.memory.*
type
pool
process.runtime.jvm.gc.duration
gc
action
process.runtime.jvm.threads.count
daemon
process.runtime.jvm.buffer
pool
Option A: No namespaces required
Possibly no change.
Maybe
gc
->name
to align with Option C.Option B: Explicit namespaces required
PR already exists for this: #20
process.runtime.jvm.memory.*
type
->memory.type
pool
->memory.pool.name
process.runtime.jvm.gc.duration
gc
->gc.name
action
->gc.action
process.runtime.jvm.threads.count
daemon
->thread.daemon
process.runtime.jvm.buffer
pool
->buffer.pool.name
Option C: Namespace inherited from metric namespace
process.runtime.jvm.memory.*
type
(implicitlyprocess.runtime.jvm.memory.type
)pool
(implicitlyprocess.runtime.jvm.memory.pool
)process.runtime.jvm.gc.duration
gc
->name
(implicitlyprocess.runtime.jvm.gc.name
)action
(implicitlyprocess.runtime.jvm.gc.action
)process.runtime.jvm.threads.count
daemon
(implicitlyprocess.runtime.jvm.threads.daemon
)process.runtime.jvm.buffer
pool
(implicitlyprocess.runtime.jvm.buffer.pool
)The text was updated successfully, but these errors were encountered: