Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace db.mssql.instance_name and db.elasticsearch.node.name with db.instance.id #542

Closed
AlexanderWert opened this issue Nov 20, 2023 · 2 comments
Closed

Replace db.mssql.instance_name and db.elasticsearch.node.name with db.instance.id #542

AlexanderWert opened this issue Nov 20, 2023 · 2 comments
Assignees
@trask

Comments

@AlexanderWert
Copy link
Member

Once, #345 is merged, we should replace db.mssql.instance_name and db.elasticsearch.node.name with the new, more generic attribute db.instance.id.
@AlexanderWert AlexanderWert changed the title Replase db.mssql.instance_name and db.elasticsearch.node.name with db.instance.id Replace db.mssql.instance_name and db.elasticsearch.node.name with db.instance.id Nov 20, 2023
@github-actions github-actions bot added the Stale label Feb 9, 2024
@joaopgrassi
Copy link
Member

Moved this to the database semconv project board

@joaopgrassi joaopgrassi removed the Stale label Feb 14, 2024
@trask trask assigned trask and unassigned joaopgrassi Apr 26, 2024
@trask
Copy link
Member

trask commented Apr 26, 2024

Closing, as SQLServer instance name is now incorporated into db.namespace, and Elastic is using db.instance.id since #738 (though that change may now be reverted in #972)

@trask trask closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trask trask

Labels
None yet
Projects
Database Client Semantic Conventions
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trask @AlexanderWert @joaopgrassi