Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"metric attributes must have namespaces" decision is not documented in the general metrics guidelines #394

Closed
joaopgrassi opened this issue Oct 12, 2023 · 3 comments · Fixed by #786
Assignees

Comments

@joaopgrassi
Copy link
Member

In #51 (comment) the TC has voted on the matter of "metric attributes must have namespaces" but the actual decision/guidelines never made to the general metric guidelines in https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md

@joaopgrassi joaopgrassi changed the title Metric attribute namespaces decision is not documented "metric attributes must have namespaces" decision is not documented in the general metrics guidelines Oct 12, 2023
@pyohannes
Copy link
Contributor

pyohannes commented Oct 30, 2023

It's already present in the general attribute naming guidelines:

This section applies to Resource, Span, Log, and Metric attribute names (also known as the "attribute keys"). [...]

Names SHOULD follow these rules:

  • Use namespacing to avoid name clashes.

This seems to be related to open-telemetry/opentelemetry-specification#3746: do we see metric naming guidelines as an extension of the general attribute naming guidelines?

@joaopgrassi
Copy link
Member Author

I feel it is an "extension" and probably everyone would benefit from it being defined in a more clear way. There is says "SHOULD" follow these rules, but AFAIK the attributes MUST have namespaces now after the TC vote.

@jsuereth
Copy link
Contributor

jsuereth commented Feb 8, 2024

We are currently treating all SHOULD guidance as MUST for our own semconv definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants