-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit system cpu attributes #325
Comments
Just a small clarification: AIUI |
I see @mx-psi! So based on this the My concern was mostly about unifying the way we represent the attributes whenever is possible. For example in that case we have the So to my mind we could just use |
Sorry for not replying on the issue, are there any questions remaining here? From the SIG I think what we discussed was that we will use the |
I think it would bring less confusion to keep it like this! Feel free to close it @mx-psi :) |
After #89 is merged we need to revisit the
system.cpu.*
attributes and specifically the thesystem.cpu.logical_number
as described at #89 (comment).The idea here is that we should be consistent with the namespace that we use for the resource attributes. To my mind it should be
host.cpu.logical_number
similarly to to thehost.id
etc.Related to #308.
The goal of this is to ensure that we preserve a unified way for reporting metrics and resource attributes as part of the
system
andhost
namespaces.This is what #226 (comment) and #324 try to address.
Also related to #130 and its implementation PRs.
cc: @open-telemetry/semconv-system-approvers
The text was updated successfully, but these errors were encountered: