Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we move common attribute documents from the spec repo to this repo? #295

Closed
joaopgrassi opened this issue Aug 31, 2023 · 1 comment · Fixed by #493
Closed

Should we move common attribute documents from the spec repo to this repo? #295

joaopgrassi opened this issue Aug 31, 2023 · 1 comment · Fixed by #493
Assignees

Comments

@joaopgrassi
Copy link
Member

There's two documents in the spec repo that are relevant to semantic conventions:

Should we consider moving those to the semantic conventions repo? I personally think they make more sense here, particularly the requirement level one.

I can work on moving them here, I just want to see what the community thinks

@mx-psi
Copy link
Member

mx-psi commented Aug 31, 2023

The 'Attribute requirement' doc is specific to semantic conventions and IMO it should definitely be on this repository, but the 'Attribute naming; doc feels like a more general document that also applies to e.g. the design of Collector/SDK processors that add attributes or the development of internal-facing conventions, and thus I would leave that one on the specification repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants