-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenAI events - yamlify body definitions and cosmetic examples improvements #1469
GenAI events - yamlify body definitions and cosmetic examples improvements #1469
Conversation
e225e77
to
c62aa16
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
18ff568
to
24b7a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. While the examples at the end of the markdown help clarify, I think the short descriptions of the input messages by role can be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing for general semconv.
Overall, glad we can now put the ToolCall structure/semantics in the YAML. I think this is a good first step.
I do think seeing the hierarchy with the spaces in markdown still leaves a bit wanting. I'm not sure what options we have with markdown here, unfortunately.
I like the look of what prometheus docs have done here but this requires dropping into HTML table land, and it ruins the readabiltiy of the markdown by itself. That may be ok if it's autogenerated.
We could switch to (pseudo) code or some form of JSON, I've heard you like designing languages, @jsuereth :) |
…or the future/customizations
24b7a60
to
557b99d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.