Move to io.opentelemetry.semconv package #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5, #2.
SemanticAttributes
now lives in a package which doesn't include*.trace.*
, which is accurate given that includes attributes used across signals.ResourceAttributes
lives in the same package asSemanticAttributes
because the additional level to the package hierarchy serves no value.The package includesDiscussed in a comment and decided to optimistically omit v1 from the package name. If later we need to make breaking changes after we release a stable version, we can skip to include v2 in the package name.v1
to give allow us to make breaking changes to the code generation logic as discussed in comment. We are still publishing an-alpha
artifact, so we are allowed to make breaking changes to the code generation logic, but I figure its best to keep the package change churn to a minimum, so trying to get us close to the structure we are likely to use when we publish a stable artifact.io.opentelemetry:opentelemetry-semconv
artifact. I think that's fine tho and we can publish deprecation warnings that point to the new classes inio.opentelemetry:opentelemetry-semconv
before deleting.