Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop strategy for deprecating / removing experimental semantic conventions #6

Closed
jack-berg opened this issue Aug 11, 2023 · 3 comments

Comments

@jack-berg
Copy link
Member

We currently maintain many outdated attributes with @Deprecated annotations and previously agreed that this is unsustainable.

For stable semantic conventions, we should obviously retain attributes indefinitely, even if they undergo allowed renames via schema transformation rules.

However, for experimental conventions, we should develop some procedure for end-of-lifing attributes as the conventions churn.

Once we develop this strategy, we should consider removing all current attributes marked as deprecated.

@breedx-splk
Copy link

breedx-splk commented Oct 25, 2023

I think as long as the prior @Deprecated version indicates what the new thing is called or what the user should use instead, then it should be safe to remove these.

Can't the "procedure" to remove these just be a simple as removing them after a release cycle has passed?

EDIT: Ok, I think I understand now -- the process suggested here is intended to help automate initiation of the deprecation itself.

@lmolkova
Copy link
Contributor

lmolkova commented Nov 21, 2023

Created generalized issue in the semconv repo - open-telemetry/semantic-conventions#550
Python has the same problem and it'd be great to have language-agnostic solution

@jack-berg
Copy link
Member Author

This is resolved. See #50 (comment) for a full summary of the strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants