Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Remote write compliance: TestRemoteWrite/otelcollector/Invalid #36

Closed
rakyll opened this issue Apr 20, 2021 · 3 comments
Closed

Remote write compliance: TestRemoteWrite/otelcollector/Invalid #36

rakyll opened this issue Apr 20, 2021 · 3 comments
Labels
conformance testing PRW conformance testing issue or PR phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Milestone
Phase 1 Implement...

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 20, 2021 •
edited
Loading

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write TestRemoteWrite/otelcollector/Invalid.

=== CONT  TestRemoteWrite/otelcollector/Invalid
    up.go:39:
        	Error Trace:	up.go:39
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/Invalid
        	Messages:   	found zero samples for up{job="test"}
@rakyll rakyll changed the title Remote write compatibility: TestRemoteWrite/otelcollector/Invalid Remote write compliance: TestRemoteWrite/otelcollector/Invalid Apr 20, 2021
@rakyll rakyll added phase1 phase1 tasks prom-exporter Prometheus exporter tasks labels Apr 20, 2021
@rakyll rakyll mentioned this issue Apr 20, 2021
Closed
@rakyll
Copy link
Contributor Author

rakyll commented Apr 21, 2021

Related to #41.

@alolita alolita added the conformance testing PRW conformance testing issue or PR label May 20, 2021
@alolita
Copy link
Member

alolita commented May 26, 2021

This test is still failing since the Up metric changes are not merged yet. (#3116)

@alolita alolita added this to the Phase 1 Implementation milestone Jun 18, 2021
@alolita
Copy link
Member

alolita commented Jun 23, 2021

#3116 is now merged. So this conformance test should pass.

@Aneurysm9 can you please confirm this test is passing?

@alolita alolita closed this as completed Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
conformance testing PRW conformance testing issue or PR phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Projects
None yet
Milestone
Phase 1 Implementation
Development

No branches or pull requests
2 participants
@rakyll @alolita