Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] translation of instrumentation scope and sampling #4744

Merged
merged 3 commits into from
Jul 2, 2024
Merged

[ja] translation of instrumentation scope and sampling #4744

merged 3 commits into from
Jul 2, 2024

Conversation

ymotongpoo
Copy link
Contributor

Docs PR Checklist

  • This PR is for a documentation page whose authoritative copy is in the
    opentelemetry.io repository.

@ymotongpoo ymotongpoo marked this pull request as ready for review June 26, 2024 00:21
@ymotongpoo ymotongpoo requested review from a team June 26, 2024 00:21
@svrnm
Copy link
Member

svrnm commented Jun 26, 2024

@katzchang please take a look!

katzchang
katzchang requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点コメントしました。
画像の文字も翻訳したいところですが、優先度的には下げて、次回という感じでいいと思います。

content/ja/docs/concepts/instrumentation-scope/index.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
@ymotongpoo
Copy link
Contributor Author

ymotongpoo commented Jun 28, 2024 •
edited
Loading

@chalin should I remove the duplicated images from this PR as well? (ref: #4741)

@ymotongpoo ymotongpoo force-pushed the ja/concepts/scope-sampling branch 5 times, most recently from 11eb75d to 77655df Compare July 2, 2024 01:21
@ymotongpoo
Copy link
Contributor Author

@svrnm @chalin could you take another look and give your LGTM?

@chalin chalin force-pushed the ja/concepts/scope-sampling branch from 77655df to db386f5 Compare July 2, 2024 21:06
chalin
chalin approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI, I've created the following issue to track the feedback form issue:

@chalin chalin merged commit 1956807 into open-telemetry:main Jul 2, 2024
16 checks passed
@ymotongpoo ymotongpoo deleted the ja/concepts/scope-sampling branch July 25, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@katzchang katzchang katzchang approved these changes

Assignees
No one assigned
Labels
lang:ja
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ymotongpoo @svrnm @katzchang @chalin