Add docs-zh-approvers to CODEOWNERS #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
|
Related to issue #4465 : Update CODEOWNERS |
3 tasks
theletterf
approved these changes
May 22, 2024
chalin
reviewed
May 27, 2024
| @@ -42,3 +42,4 @@ content/en/docs/specs/ @open-telemetry/docs-approvers @open-te | |||
| content/en/docs/security/ @open-telemetry/docs-approvers @open-telemetry/sig-security-maintainers | |||
| content/en/ecosystem/demo/ @open-telemetry/demo-approvers @open-telemetry/demo-approvers | |||
| content/en/docs/contributing/ @open-telemetry/docs-approvers @open-telemetry/docs-maintainers | |||
| content/zh/ @open-telemetry/docs-zh-approvers | |||
There was a problem hiding this comment.
I'd like to suggest that content/zh/ also have @open-telemetry/docs-approvers, if only initially, as we iron out the wrinkles in the process. @open-telemetry/docs-approvers can always RSLGTM for PRs that are pure content, but as we ramp up there are likely to be "structural" / Hugo / Docsy / tooling related issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @open-telemetry/docs-zh-approvers as codeowners for docs/zh, since @open-telemetry/docs-zh-maintainers is a subteam they inherit that ownership and do not need to be mentioned