Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otecol-data-flow-dashboard documentation #2569

Merged
merged 1 commit into from
Apr 3, 2023
Merged

otecol-data-flow-dashboard documentation #2569

merged 1 commit into from
Apr 3, 2023

Conversation

devrimdemiroz
Copy link
Contributor

replacement for feature/otecol-data-flow-dashboard-PR797

@devrimdemiroz devrimdemiroz requested review from a team April 3, 2023 07:19
@devrimdemiroz devrimdemiroz mentioned this pull request Apr 3, 2023
Closed
cartermp
cartermp approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For posterity, here's the discussion leading to the new PR: #2538 (comment)

@cartermp cartermp merged commit 342d91f into open-telemetry:main Apr 3, 2023
@devrimdemiroz devrimdemiroz deleted the feature/otecol-data-flow-dashboard-PR797-3 branch April 3, 2023 16:21
@devrimdemiroz devrimdemiroz mentioned this pull request Apr 3, 2023
Merged
2 tasks
@chalin
Copy link
Contributor

chalin commented Apr 4, 2023

Woohoo! Glad that this has landed. Thanks @devrimdemiroz! ✨

@devrimdemiroz
Copy link
Contributor Author

Woohoo! Glad that this has landed. Thanks @devrimdemiroz! ✨

@chalin Thank you for sharing your insights and recommendations in general and especially about the positioning of images in the document. After publishing, I have come to understand the validity of your perspective.

I am grateful for your patience and cooperation as we navigated this issue together.

Collaborating with someone as skilled and experienced as you is always a great experience. I appreciate your constructive feedbacks, which has undoubtedly contributed to the quality of the document.

@reyang
Copy link
Member

reyang commented Apr 4, 2023

@devrimdemiroz this is awesome! Thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devrimdemiroz @chalin @reyang @cartermp