Create docs-zh-approvers etc

[chalin]

@open-telemetry/docs-maintainers : given that we'll soon have Chinese language content, shall we create an OTel org-level team, say, docs-zh-approvers. That would make official who the custodians of those pages are, and make it possible to set CODEOWNERS, etc.

Tasks

• New teams docs-zh-approvers and docs-zh-maintainers community#2107
• Update CODEOWNERS - Add docs-zh-approvers to CODEOWNERS #4522
• CODEOWNERS: add docs-maintainers to zh folder for now #4584

Reference

• https://github.com/orgs/open-telemetry/teams/docs-approvers

[svrnm]

Yes, we need that. There are docs-cn-approvers and docs-cn-maintaines already, who own https://github.com/open-telemetry/docs-cn. Not sure why there are no groups for docs-ja repo.

[chalin]

Since cn isn't an official language code, it might be better to use zh so that we have a consistent pattern for all languages that the website might eventually support.

[svrnm]

As a point of reference, kubernetes has https://kubernetes.io/zh-cn/

[chalin]

Right, they use a region-specific language code (zh-cn) rather than the more general zh. We need to consider if we want to follow suite.

I guess that in that sense @open-telemetry/docs-cn-maintainers and @open-telemetry/docs-cn-approvers might be file.

But, depending on the outcome / feedback regarding #2402 (comment), we might not need to do anything more.

[windsonsea]

IMO, all of these language code for Chinese are easy to understand. One concern is to keep consistency in the entire OTel org. We can pick one and use it throughly:

• zh
• zh-cn
• cn

[svrnm]

Thanks @windsonsea

A few more data points from CNCF

• https://glossary.cncf.io/zh-cn/
• Kubernetes uses zh-cn (see above) but the github team is zh: https://github.com/kubernetes/website/blob/main/data/i18n/zh-cn/OWNERS

[chalin]

I'd vote for zh, like GH. Whilezh-cn is an official language code, AFAIK, cn is not.

Edit: ok, to be clear, because this issue is referring to GH groups, for the group name, it probably doesn't matter much (as to whether it's an official language code or not): so we could "reuse" the existing groups, ... maybe?

As for the language code for the OTel website: the language code is currently set to zh. Shall we stick to that or follow CNCF sibling sites?

[chalin]

@svrnm - how about creating a label for Chinese page changes -- such as, say, lang:zh?

[windsonsea]

Yes, it would be helpful to add a label to clearly identify zh translations. Additionally, we should set the CODEOWNERs to docs-zh-approvers and assign PRs with the lang:zh label to this team.

If possible, I would greatly appreciate becoming a member of the docs-zh-approvers team. 😄

[svrnm]

label lang:zh created, I also provided a PR (#4480) to get it automatically applied on changes to content/zh

[svrnm]

See open-telemetry/community#2107

[chalin]

Reopening until we answer the following question:

Originally posted by @chalin in #4522 (comment)

I'd like to suggest that content/zh/ also have @open-telemetry/docs-approvers, if only initially, as we iron out the wrinkles in the process. @open-telemetry/docs-approvers can always RSLGTM for PRs that are pure content, but as we ramp up there are likely to be "structural" / Hugo / Docsy / tooling related issues.

[windsonsea]

Could we grant zh-approvers the permission to merge only the content/zh docs? This would apply to PRs labeled with lang:zh.

[svrnm]

Could we grant zh-approvers the permission to merge only the content/zh docs? This would apply to PRs labeled with lang:zh.

Tbh, I am not exactly sure if/how we can configure the repository to make this possible.

[chalin]

I'd keep it simple, and for the next couple of months, just add @open-telemetry/docs-maintainers over the zh folder.

[chalin]

Here's my proposal for now:

• CODEOWNERS: add docs-maintainers to zh folder for now #4584