Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics terminology (Adding/Grouping) #983

Merged
merged 8 commits into from
Sep 25, 2020
Merged

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Sep 22, 2020

Changes

Apply #625 decision to the API spec: The term "Additive" is replaced by "Adding", and "Non-Additive" is replaced by "Grouping". See the comment here.

Fixes #625.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Sep 22, 2020
@jmacd jmacd requested review from a team September 22, 2020 07:08
Thank you @jkwatson.

Co-authored-by: John Watson <[email protected]>
@bogdandrutu
Copy link
Member

Please rebase

specification/metrics/api.md Outdated Show resolved Hide resolved
specification/metrics/api.md Outdated Show resolved Hide resolved
@jmacd
Copy link
Contributor Author

jmacd commented Sep 25, 2020

This is ready to merge.

@arminru arminru merged commit 7561ec6 into open-telemetry:master Sep 25, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics terminology: Grouping instruments as (opposed to Adding instruments)
6 participants