Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add environment attribute: Deployment Environment #606

Merged
merged 2 commits into from
Aug 21, 2020
Merged

add environment attribute: Deployment Environment #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09eb79a
Add "Deployment / environment" subsection in "Environment"
ecourreges-orange Aug 5, 2020
ba44c58
Merge branch 'master' into master
carlosalberto Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions specification/resource/semantic_conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ This document defines standard attributes for resources. These attributes are ty
- [Service](#service)
- [Telemetry SDK](#telemetry-sdk)
- [Compute Unit](#compute-unit)
- [Deployment Service](#deployment-service)
- [Compute Instance](#compute-instance)
- [Environment](#environment)
- [Version Attributes](#version-attributes)
Expand Down Expand Up @@ -90,12 +89,6 @@ Attributes defining a compute unit (e.g. Container, Process, Function as a Servi
- [Function as a Service](./faas.md)
- [Process](./process.md)

## Deployment Service

Attributes defining a deployment service (e.g. Kubernetes):

- [Kubernetes](./k8s.md)

## Compute Instance

Attributes defining a computing instance (e.g. host):
Expand All @@ -104,10 +97,13 @@ Attributes defining a computing instance (e.g. host):

## Environment

Attributes defining a running environment (e.g. Operating System, Cloud, Data Center):
Attributes defining a running environment (e.g. Operating System, Cloud, Data Center, Deployment Service):

- [Operating System](./os.md)
- [Cloud](./cloud.md)
- Deployment:
- [Environment](./deployment_environment.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Environment/ProductionEnvironment?

Or maybe "Environment Stage"?

"Environment" is a bit too generic I feel like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the feedback here (either way) @ecourreges-orange ;)

- [Kubernetes](./k8s.md)

## Version Attributes

Expand Down
9 changes: 9 additions & 0 deletions specification/resource/semantic_conventions/deployment_environment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Deployment

**type:** `deployment`

**Description:** The software deployment.

| Attribute | Description | Example | Required? |
|---|---|---|---|
| deployment.environment | Name of the [deployment environment](https://en.wikipedia.org/wiki/Deployment_environment) (aka deployment tier) | `staging` , `production` | No |