From 05c954fee12f1ed5f1a21fa74070465ba8cbf334 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 2 Sep 2022 15:46:44 -0700 Subject: [PATCH 1/5] Change the default buckets for Explicit Bucket Histogram --- specification/metrics/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 402e2b14d6e..f9f72f683b6 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -431,7 +431,7 @@ This Aggregation honors the following configuration parameters: | Key | Value | Default Value | Description | | --- | --- | --- | --- | -| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 1000 ] | Array of increasing values representing explicit bucket boundary values.

The Default Value represents the following buckets:
(-∞, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 1000.0], (1000.0, +∞) | +| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000 ] | Array of increasing values representing explicit bucket boundary values.

The Default Value represents the following buckets (heavily influenced by the default buckets of Prometheus clients, e.g. [Java](https://github.com/prometheus/client_java/blob/6730f3e32199d6bf0e963b306ff69ef08ac5b178/simpleclient/src/main/java/io/prometheus/client/Histogram.java#L88) and [Go](https://github.com/prometheus/client_golang/blob/83d56b1144a0c2eb10d399e7abbae3333bebc463/prometheus/histogram.go#L68)):
(-∞, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 750.0], (750.0, 1000.0], (1000.0, 2500.0], (2500.0, 5000.0], (5000.0, 7500.0], (7500.0, 10000.0], (10000.0, +∞) | | RecordMinMax | true, false | true | Whether to record min and max. | Explicit buckets are stated in terms of their upper boundary. Buckets From 8202ef02b0954a0c30b1c38858487d668af68ab2 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 2 Sep 2022 15:52:08 -0700 Subject: [PATCH 2/5] changelog --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6678a018963..453f72934b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,9 @@ release. ([#2538](https://github.com/open-telemetry/opentelemetry-specification/pull/2538)). - Add `process.threads` host metric semantic convention. ([#2705](https://github.com/open-telemetry/opentelemetry-specification/pull/2705)). +- Changed the default buckets for Explicit Bucket Histogram to better match the + official Promethues Clients. + ([#2770](https://github.com/open-telemetry/opentelemetry-specification/pull/2770)). ### Logs From 4bded9d831614a78c56e45fb5130939a160b467f Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Fri, 2 Sep 2022 15:54:54 -0700 Subject: [PATCH 3/5] fix typo --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 453f72934b5..c77f90b7484 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,7 +27,7 @@ release. - Add `process.threads` host metric semantic convention. ([#2705](https://github.com/open-telemetry/opentelemetry-specification/pull/2705)). - Changed the default buckets for Explicit Bucket Histogram to better match the - official Promethues Clients. + official Prometheus clients. ([#2770](https://github.com/open-telemetry/opentelemetry-specification/pull/2770)). ### Logs From faa2e3236aaa01a93e43866710d5eefbd4f7908e Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 20 Sep 2022 16:15:48 -0700 Subject: [PATCH 4/5] making default a SHOULD --- specification/metrics/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index f9f72f683b6..233d93fa210 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -431,7 +431,7 @@ This Aggregation honors the following configuration parameters: | Key | Value | Default Value | Description | | --- | --- | --- | --- | -| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000 ] | Array of increasing values representing explicit bucket boundary values.

The Default Value represents the following buckets (heavily influenced by the default buckets of Prometheus clients, e.g. [Java](https://github.com/prometheus/client_java/blob/6730f3e32199d6bf0e963b306ff69ef08ac5b178/simpleclient/src/main/java/io/prometheus/client/Histogram.java#L88) and [Go](https://github.com/prometheus/client_golang/blob/83d56b1144a0c2eb10d399e7abbae3333bebc463/prometheus/histogram.go#L68)):
(-∞, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 750.0], (750.0, 1000.0], (1000.0, 2500.0], (2500.0, 5000.0], (5000.0, 7500.0], (7500.0, 10000.0], (10000.0, +∞) | +| Boundaries | double\[\] | [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000 ] | Array of increasing values representing explicit bucket boundary values.

The Default Value represents the following buckets (heavily influenced by the default buckets of Prometheus clients, e.g. [Java](https://github.com/prometheus/client_java/blob/6730f3e32199d6bf0e963b306ff69ef08ac5b178/simpleclient/src/main/java/io/prometheus/client/Histogram.java#L88) and [Go](https://github.com/prometheus/client_golang/blob/83d56b1144a0c2eb10d399e7abbae3333bebc463/prometheus/histogram.go#L68)):
(-∞, 0], (0, 5.0], (5.0, 10.0], (10.0, 25.0], (25.0, 50.0], (50.0, 75.0], (75.0, 100.0], (100.0, 250.0], (250.0, 500.0], (500.0, 750.0], (750.0, 1000.0], (1000.0, 2500.0], (2500.0, 5000.0], (5000.0, 7500.0], (7500.0, 10000.0], (10000.0, +∞). SDKs SHOULD use the default value when boundaries are not explicitly provided, unless they have good reasons to use something different (e.g. for backward compatibility reasons in a stable SDK release). | | RecordMinMax | true, false | true | Whether to record min and max. | Explicit buckets are stated in terms of their upper boundary. Buckets From 175b4b29fe91c135a7037691f55901700f044f1e Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Wed, 21 Sep 2022 08:05:27 -0700 Subject: [PATCH 5/5] move changelog to unreleased section --- CHANGELOG.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a98b081fb8b..baa1adff61d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ release. ### Metrics +- Changed the default buckets for Explicit Bucket Histogram to better match the + official Prometheus clients. + ([#2770](https://github.com/open-telemetry/opentelemetry-specification/pull/2770)). + ### Logs ### Resource @@ -69,9 +73,6 @@ release. ([#2633](https://github.com/open-telemetry/opentelemetry-specification/pull/2633)) - Add `process.threads` host metric semantic convention. ([#2705](https://github.com/open-telemetry/opentelemetry-specification/pull/2705)). -- Changed the default buckets for Explicit Bucket Histogram to better match the - official Prometheus clients. - ([#2770](https://github.com/open-telemetry/opentelemetry-specification/pull/2770)). ### Logs