-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are IsValid and IsRemote required? #908
Comments
If it's stated like a fact, it's a MUST, I'd say. |
Just based on your response alone it should be clear that assuming things will be interpreted in a particular way is subjective. Subjectivity does not have a place in a specification that is laying out directives for compliance. It is also not something found in the notation conventions this project has stated it adheres to. This issue is asking for any subjective understanding of the authors to be communicated in the specification explicitly by following this notational conventions. I would also ask this be done prior to GA as I am still not certain if these are requirements, recommendations, or suggestions for a SIG to implement. |
I agree that this would be preferable, and feel free to create a PR to exchange every fact (not annotated with "Note:") with a MUST. But I don't think it's very urgent. Others might disagree though, so I'll remove the after-ga label and let others decide. EDIT: Let's also say this is a bug. |
@open-telemetry/javascript-maintainers According to the spec compliance matrix, JS is the only implementation known to not implement |
@MrAlias Do you want to open a new issue for cleaning up the whole spec for MUSTs stated as facts? This could be resolved either by adding the MUSTs or stating that every fact not annotated with Note/usually/is expected to is a MUST and checking the spec for facts that should be notes. |
@arminru there is a PR open for it. Simply a matter of limited developer hours and other priorities. |
I'm open to suggestions, but my initial thought would be to open issues for underspecified portions of the spec as they are identified. I'm guessing your are more familiar with the entirety of the specification and might have more insight into the total scope of areas that need these types of revisions so I would be interested to understand what your think is the appropriate course of action and what size you think the scope of this is @Oberon00. |
Personally I think we can do this on an on-demand base. So we can just close this issue with #914 then and open a new one if something particular comes up. |
Currently the SpanContext section contains both
IsValid
andIsRemote
as subsections. There is not normative statements given about if these portions of the API are required, recommended, or options as far as I can tell.To make the specification clear about what implementations must, should, or can include this should be made explicit.
The text was updated successfully, but these errors were encountered: