Should SpanProcessor.OnStart/OnEnd be called for non-recording Spans? #782
Labels
area:sampling
Related to trace sampling
area:sdk
Related to the SDK
priority:p3
Lowest priority level
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
spec:trace
Related to the specification/trace directory
As discussed in the SIG meeting, this issue is split from #634.
In https://github.com/open-telemetry/opentelemetry-specification/blob/bc272ab52869df2145065d55300d721ff008e34b/specification/trace/sdk.md#shouldsample, the spec describes that when the sampler returns NOT_RECORD, then
Should the SpanProcessor be notified in this case? If so, should it only be notified for the start event, or also for the end event (OnStart can be invoked immediately without much hassle; OnEnd would preclude implementation of an unsampled span with a default span, because it would need a reference to its SpanProcessor).
I assume we agree that the SpanProcessor must be invoked for not sampled but recorded spans, but this could also be made explicit.
Assigned @alolita as per #634 (comment)
The text was updated successfully, but these errors were encountered: