Formalize the translation of OpenTracing references to span parent and links #562
Labels
area:sdk
Related to the SDK
priority:p2
Medium priority level
release:allowed-for-ga
Editorial changes that can still be added before GA since they don't require action by SIGs
spec:trace
Related to the specification/trace directory
In the Java shim, the first reference is used as the parent regardless of the reference type: https://github.com/open-telemetry/opentelemetry-java/blob/v0.3.0/opentracing_shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java#L74-L89
In Golang, its the first
CHILD_OF
: https://github.com/open-telemetry/opentelemetry-go/blob/v0.4.2/bridge/opentracing/bridge.go#L540-L548In the Jaeger Java client, when spans are converted to thrift, the parent is set if and only if there is a single child reference: https://github.com/jaegertracing/jaeger-client-java/blob/v1.2.0/jaeger-thrift/src/main/java/io/jaegertracing/thrift/internal/reporters/protocols/JaegerThriftSpanConverter.java#L50. I'm currently hitting this using the thrift HTTP receiver in the opentelemetry-collector. See jaegertracing/jaeger-client-java#705 for tracking this behaviour.
The spec should explicitly call out what the translation should be to avoid inconsistencies when translating to OTel.
The text was updated successfully, but these errors were encountered: