-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics: Consider removing the WithRecommendedKeys
option
#463
Comments
Discussed this in the SIG today. There is a motion to remove this from the API and include it in the Views API. |
See this comment: #466 (comment) |
@jmacd if we expect to specify custom aggregations in the view can we go ahead and remove |
I believe Bogdan volunteered to take care of this. If we think it's not a big deal to modify the spec directly, feel free to go ahead. :-) |
This option was given as a requirement to support configuration-free good defaults for exporting to Prometheus systems, specifically. However, it's been shown that Prometheus' protocol does not actually depend on this, only its client libraries do. Since we have bypassed Prometheus's client libraries for our OTel SDKs, this is no longer necessary.
At the same time, this issue bleeds into other open discussions, for example relating to whether users should be able to specify custom aggregations for an instrument, whether at the point of definition (i.e., while constructing an instrument) or at a separate point (e.g., while configuring a view).
The group is leaning toward support for a Views API and removing the ability for users to specify aggregations and/or aggregation dimensions at the point of definition.
See this comment: #430 (comment)
The text was updated successfully, but these errors were encountered: