Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric aggregation env variables are only for OTLP Exporter #4248

Open
cijothomas opened this issue Oct 8, 2024 · 6 comments
Open

Metric aggregation env variables are only for OTLP Exporter #4248

cijothomas opened this issue Oct 8, 2024 · 6 comments
Labels
spec:metrics Related to the specification/metrics directory triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details

Comments

@cijothomas
Copy link
Member

What are you trying to achieve?
Trying to influence Metric aggregation temporality, aggregation for histograms when using non-otlp exporting.

What did you expect to see?

A MeterProvider/MetricReader env variable to control the same.
However, the existing env variables are tied to OTLP Exporter only, and does not work when other exporting is used:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/otlp.md#additional-environment-variable-configuration

I think these variables should be respected by the SDK (after changing the name to remove "OTLP" from them).

@cijothomas cijothomas added the spec:metrics Related to the specification/metrics directory label Oct 8, 2024
@cijothomas
Copy link
Member Author

#4246 (comment)

@svrnm svrnm added the triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted label Oct 14, 2024
@pellared
Copy link
Member

I think it is better to have the _OTLP_ and also other exporters would also have its own _[NAME]_ as it would allow better granularity when multiple exporters are used.

Moreover, the current env vars are stable.

Therefore, I would rather propose defining equivalent env vars for other exporters than removing _OTLP_.

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Oct 29, 2024
@trask
Copy link
Member

trask commented Nov 5, 2024

I would rather propose defining equivalent env vars for other exporters than removing OTLP.

@cijothomas which other metric exporters are you wanting to define this for?

@trask trask removed the triage:followup Needs follow up during triage label Nov 5, 2024
@cijothomas
Copy link
Member Author

I would rather propose defining equivalent env vars for other exporters than removing OTLP.

@cijothomas which other metric exporters are you wanting to define this for?

For example, stdout - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/stdout.md

There are also other exporters not part of the spec, that won't be able to leverage this env variable today as its tied to OTLP Exporter.
Other env variables like the one controlling Exemplars are not tied to OTLPExporter. However OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION is another which seems tied to OTLPExporter.

@trask
Copy link
Member

trask commented Nov 6, 2024

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Nov 6, 2024
@svrnm svrnm removed the triage:followup Needs follow up during triage label Nov 25, 2024
@svrnm
Copy link
Member

svrnm commented Nov 25, 2024

@cijothomas any comments on @trask's question?

@github-actions github-actions bot added the triage:followup Needs follow up during triage label Nov 26, 2024
@danielgblanco danielgblanco added triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details and removed triage:deciding:community-feedback Open to community discussion. If the community can provide sufficient reasoning, it may be accepted triage:followup Needs follow up during triage labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory triage:deciding:needs-info Not enough information. Left open to provide the author with time to add more details
Projects
None yet
Development

No branches or pull requests

5 participants