-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle explicit deviations to the spec? #2097
Comments
More context: open-telemetry/oteps#232 (review) |
My initial inclination would be to have these deviations documented somewhere in this repository, where they will get visibility and implicit sign-off from TC members via PR. |
My understanding of this statement is pretty clear, the .NET implementation is not compliant if they do not satisfy all the requirements:
If parts of the specification are not applicable or don't make sense for an implementation they need to work with the specification to modify it so they can comply with it. Otherwise, whats the point of having a specification? |
I also think that the .NET model of implementing most core things in the Microsoft-owned dotnet/runtime repository does not align well with OpenTelemetry procedures and governance. Instead of declaring it "stable" it is more like "N/A" and despite the name opentelemetry-dotnet is not really an OpenTelemetry implementation but a project that provides functionality very similar to OpenTelemetry for .NET. Definitely similar enough to warrant not re-implementing an OpenTelemetry client library for .NET, but it's not really a full OpenTelemetry either. |
Bringing over my comment from the discussion on OTEP 232:
|
The GC is going to handle creating a policy around this |
@austinlparker, do you remember if there was movement around this already? |
I don't think it's made it to an agenda yet. |
During the discussion of open-telemetry/oteps#232, a previous version of that proposal stated that language SIGs would only be considered stable once they implemented the stable parts of the API and SDK specs. The dotnet maintainers brought up the point that not everything in the spec makes sense for dotnet, and it shouldn't prevent the dotnet SDK/API from being called stable.
While the dotnet-specific parts are interesting, I think we have a more generic matter to discuss: if a SIG determines that a required part of the spec shouldn't be implemented, should the deliverable still be considered stable? Who should make this call? Should a TC waiver be provided?
The text was updated successfully, but these errors were encountered: