Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: extend Sampler interface so that shouldSample receive the Instrumentation Scope as input #3656

Closed
albertored opened this issue Aug 12, 2023 · 2 comments
Closed

Proposal: extend Sampler interface so that shouldSample receive the Instrumentation Scope as input #3656

albertored opened this issue Aug 12, 2023 · 2 comments
Assignees
@tigrannajaryan
Labels
spec:trace Related to the specification/trace directory

Comments

@albertored
Copy link
Contributor

I would like to propose an addition to the arguments of the shouldSample function of the Sampler interface. In particular, I would like to have also the Instrumentation Scope as an argument.

This will help custom samplers to achieve some specific sampling decisions, for instance my use case is being able to drop all spans generated by a specific instrumentation library.
@albertored albertored added the spec:trace Related to the specification/trace directory label Aug 12, 2023
@MrAlias
Copy link
Contributor

MrAlias commented Aug 12, 2023

Duplicate of #1588?

@albertored
Copy link
Contributor Author

Yes, sorry, I searched for it but didn't find it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tigrannajaryan @MrAlias @albertored