Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define built-in processor to add log.record.uid if missing #3277

Open
jack-berg opened this issue Mar 2, 2023 · 2 comments
Open

Define built-in processor to add log.record.uid if missing #3277

jack-berg opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
spec:logs Related to the specification/logs directory

Comments

@jack-berg
Copy link
Member

#3047 adds semantic conventions for log.record.uid. I proposed that it would be useful for the SDK to automatically add this attribute.

This is a natural use case for another built-in LogRecordProcessor.

Let's define a standard LogRecordProcessor which adds log.record.uid to LogRecords if it is not already present. It can add guids, or ulids, or perhaps be configurable with a custom id generator to allow users to generate their own ids.

@jack-berg jack-berg added the spec:logs Related to the specification/logs directory label Mar 2, 2023
@joaopgrassi
Copy link
Member

I think this is a nice idea and would allow augmenting logs in the future if necessary. One thing I was thinking, would the addition to this cause any breaking change? Giving the Logs API/SDK is getting close to stable maybe it's worth considering?

@jack-berg
Copy link
Member Author

I can't think of any reason why it can't be a backwards compatible addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

No branches or pull requests

3 participants