Add db.redis.arguments for requests and responses

[haddasbronfman]

What are you trying to achieve?

I want to add to the database semantic conventions additional attributes for redis spans.
The value of adding the metadata is to help users get more information from the traces which could allow for easier troubleshooting.

I propose the following names for the attribute:

• db.redis.arguments

[carlosalberto]

Hey @haddasbronfman - would you mind mentioning examples/use cases?

[haddasbronfman]

Hi, sure:
example 1 - hset command:
attributes: { 'db.system': 'redis', 'db.statement': 'hset', 'db.redis.arguments': '["myhash","key1","value1"]', }

example 2 - hgetall command:
attributes: { 'db.system': 'redis', 'db.statement': 'hgetall', 'db.redis.arguments': '["myhash"]', }

example 3 - hkeys command:
attributes: { 'db.system': 'redis', 'db.statement': 'hkeys', 'db.redis.arguments': '["myhash"]', }

example 4 - hget command:
attributes: { 'db.system': 'redis', 'db.statement': 'hget', 'db.redis.arguments': '["myhash","key1"]', }

example 5 - del command:
attributes: { 'db.system': 'redis', 'db.statement': 'del', 'db.redis.arguments': '["key1"]', }

[tigrannajaryan]

Does this need to be Redis specific? I see for example a very similar request that is more generic: https://cloud-native.slack.com/archives/C01N7PP1THC/p1668007675690439

[haddasbronfman]

I wrote it specifically for Redis, but you're right there might be more databases that this attribute can fit to.
How can we proceed from here?

[tigrannajaryan]

I wrote it specifically for Redis, but you're right there might be more databases that this attribute can fit to. How can we proceed from here?

See if you can generalize it and make applicable to other database and name appropriately (e.g. db.statement_arguments or similar).

[carlosalberto]

So in theory we should be reporting the arguments as part of the statement, as per the Spec:

SELECT * FROM wuser_table; SET mykey "WuValue"

So we should poke the instrumentation authors. @haddasbronfman what instrumentation/language/version are you using?

[haddasbronfman]

@carlosalberto you're right. I opened this issue: open-telemetry/opentelemetry-js-contrib#1294
to handle this.
We can close this one.