Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exporters should add their version information as a resource attribute #2501

Open
codeboten opened this issue Apr 19, 2022 · 3 comments
Assignees
Labels
area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label

Comments

@codeboten
Copy link
Contributor

As a result of the discussion in April 19th SIG meeting, it was suggested that it would be useful for debugging purposes that the OTLP exporter add version information to the resource attributes it emits.

@codeboten codeboten added the spec:miscellaneous For issues that don't match any other spec label label Apr 19, 2022
@arminru arminru added the area:sdk Related to the SDK label Apr 26, 2022
@arminru
Copy link
Member

arminru commented Apr 26, 2022

This is not about the version of the exporter component but the opentelemetry-proto version the payload conforms to, right?

@bogdandrutu
Copy link
Member

No, it is about the version of the exporter component. We decided intentionally to not add the version of the opentelemetry-proto to disallow backends to do business decisions based on the proto version. This information can be used only for metrics/debugging purpose.

@arminru arminru changed the title OTLP exporter should add a version information as a resource attribute OTLP exporters should add their version information as a resource attribute Apr 26, 2022
@alanwest
Copy link
Member

Maybe worthy of a separate issue, but I think it also makes sense to add this information in the user-agent (or equivalent). Much in the same way that was done in the collector project open-telemetry/opentelemetry-collector#3970.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

4 participants