Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the need and the difference between supported and preferred temporality? #2130

Closed
bogdandrutu opened this issue Nov 16, 2021 · 1 comment · Fixed by #2154
Closed

Clarify the need and the difference between supported and preferred temporality? #2130

bogdandrutu opened this issue Nov 16, 2021 · 1 comment · Fixed by #2154
Assignees
@bogdandrutu
Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@bogdandrutu
Copy link
Member

From https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#temporality-override-rules it seems that if there is a "preferred" use that -> it can translate into I support only the "preferred". No need for the both concepts if setting the "preferred" means will produce that anyway.
@bogdandrutu bogdandrutu added the spec:metrics Related to the specification/metrics directory label Nov 16, 2021
@bogdandrutu bogdandrutu mentioned this issue Nov 17, 2021
Merged
@reyang reyang added the area:sdk Related to the SDK label Nov 17, 2021
@reyang reyang added the release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs label Nov 23, 2021
@reyang reyang assigned reyang and unassigned jsuereth Nov 23, 2021
@reyang
Copy link
Member

reyang commented Nov 23, 2021

@bogdandrutu had a question if we need both - if we need both and later we remove one, it'll be a breaking change.

@reyang reyang added release:required-for-ga Must be resolved before GA release, or nice to have before GA and removed release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Nov 23, 2021
@reyang reyang assigned bogdandrutu and unassigned reyang Nov 23, 2021
@bogdandrutu bogdandrutu mentioned this issue Nov 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdandrutu bogdandrutu

Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the concept of supported temporality, keep preferred bogdandrutu/opentelemetry-specification
3 participants
@jsuereth @bogdandrutu @reyang