Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the Included Propagators section a duplicate of Propagators Distribution? #1544

Closed
MrAlias opened this issue Mar 12, 2021 · 0 comments · Fixed by #1556 · May be fixed by open-telemetry/opentelemetry-python-contrib#1662
Closed
Labels
bug Something isn't working spec:trace Related to the specification/trace directory

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 12, 2021

The Included Propagators section specifies that a W3C tracecontext propagator must be included in the API, however the Propagators Distribution also mentions that a W3C tracecontext propagator must be included (though it says it MAY be included directly in the API).

This seems like duplicate specification at best and possibly even conflicting specification.

The duplication of this specification should be resolved by unifying on the location of this information. It seems Propagators Distribution is the more comprehensive body of work so it seems a better fit there.

The requirement or option that the implementation be included in the API needs to be resolved. Easing a requirement is a backwards compatible change as opposed to making an option now a requirement. Therefore, it would seem the best course of action here is to resolve this by specifying it is an OPTION to be distributed as part of the OpenTelemetry API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec:trace Related to the specification/trace directory
Projects
None yet
1 participant