Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForceFlush to Tracing SDK #1451

Closed
kipwoker opened this issue Feb 19, 2021 · 1 comment · Fixed by #1452
Closed

Add ForceFlush to Tracing SDK #1451

kipwoker opened this issue Feb 19, 2021 · 1 comment · Fixed by #1452
Labels
area:sdk Related to the SDK spec:trace Related to the specification/trace directory

Comments

@kipwoker
Copy link
Contributor

What are you trying to achieve?

I want to add ForceFlush to Tracing SDK like it was done for the Shutdown method.

Additional context.

I'm using OpenTelemetry for AWS lambda functions. And I'm using dotnet opentelemetry library to achieve that. After each call, lambda goes to sleep and freezes background threads. Therefore I need to send activities to the exporter forcibly if I want to use the batch processor instead of the simple one.

Thankfully, BaseProcessor already contains a ForceFlush method that works perfectly in this case.

There is a PR that I've made for the dotnet library: open-telemetry/opentelemetry-dotnet#1837
My PR is based on a similar Java PR, which you can find here. And the Java PR has already been merged.

cc: @reyang @utpilla @cijothomas

@kipwoker kipwoker added the spec:trace Related to the specification/trace directory label Feb 19, 2021
@Oberon00 Oberon00 added the area:sdk Related to the SDK label Feb 19, 2021
@Oberon00
Copy link
Member

Seems it was more or less an oversight that this was not there from the beginning together with Shutdown #1073 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants