Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin spec should suggest to use Resource.GetDefault #1380

Closed
cijothomas opened this issue Jan 27, 2021 · 0 comments · Fixed by #1386
Closed

Zipkin spec should suggest to use Resource.GetDefault #1380

cijothomas opened this issue Jan 27, 2021 · 0 comments · Fixed by #1386
Labels
area:sdk Related to the SDK priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory

Comments

@cijothomas
Copy link
Member

These 2 PRs modified default resource requirements.
#1269
#1294

Zipkin exporter spec must be updated to reflect this change.
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/zipkin.md#service-name
@cijothomas cijothomas added spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory labels Jan 27, 2021
@cijothomas cijothomas mentioned this issue Jan 27, 2021
Closed
@carlosalberto carlosalberto added area:sdk Related to the SDK priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Jan 27, 2021
@carlosalberto carlosalberto mentioned this issue Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:sdk Related to the SDK priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
2 participants
@carlosalberto @cijothomas