From ea5cbf73cbb6b9fa5c93ca815efe7b24cce9eab7 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Fri, 24 Feb 2023 07:59:43 -0800 Subject: [PATCH] Rename nonheap to non_heap (#3250) Fixes https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7876 (the implementation used `non_heap`, which seems better) ## Changes Renames JVM metric attribute value from `nonheap` to `non_heap`. --------- Co-authored-by: Carlos Alberto Cortez --- CHANGELOG.md | 2 ++ .../runtime-environment-metrics.md | 10 +++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc9523b7635..16a02de32b0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,8 @@ release. ([#3209](https://github.com/open-telemetry/opentelemetry-specification/pull/3209)) - Add Connect RPC specific conventions ([#3116](https://github.com/open-telemetry/opentelemetry-specification/pull/3116)) +- Rename JVM metric attribute value from `nonheap` to `non_heap` + ([#3250](https://github.com/open-telemetry/opentelemetry-specification/pull/3250)) - Mark the attribute naming guidelines in the specification as stable. ([#3220](https://github.com/open-telemetry/opentelemetry-specification/pull/3220)) diff --git a/specification/metrics/semantic_conventions/runtime-environment-metrics.md b/specification/metrics/semantic_conventions/runtime-environment-metrics.md index 8a58c9aab3d..5b68cb22a4b 100644 --- a/specification/metrics/semantic_conventions/runtime-environment-metrics.md +++ b/specification/metrics/semantic_conventions/runtime-environment-metrics.md @@ -63,15 +63,15 @@ All JVM metric attributes are required unless otherwise indicated. | Name | Description | Unit | Unit ([UCUM](README.md#instrument-units)) | Instrument Type ([*](README.md#instrument-types)) | Value Type | Attribute Key | Attribute Values | |------------------------------------------------|-------------------------------------------------------------------------------------------------|--------------|-------------------------------------------|---------------------------------------------------|------------|---------------|-----------------------| -| process.runtime.jvm.memory.usage | Measure of memory used | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"nonheap"` | +| process.runtime.jvm.memory.usage | Measure of memory used | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"non_heap"` | | | | | | | | pool | Name of pool [1] | -| process.runtime.jvm.memory.init | Measure of initial memory requested | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"nonheap"` | +| process.runtime.jvm.memory.init | Measure of initial memory requested | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"non_heap"` | | | | | | | | pool | Name of pool [1] | -| process.runtime.jvm.memory.committed | Measure of memory committed | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"nonheap"` | +| process.runtime.jvm.memory.committed | Measure of memory committed | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"non_heap"` | | | | | | | | pool | Name of pool [1] | -| process.runtime.jvm.memory.limit | Measure of max obtainable memory | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"nonheap"` | +| process.runtime.jvm.memory.limit | Measure of max obtainable memory | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"non_heap"` | | | | | | | | pool | Name of pool [1] | -| process.runtime.jvm.memory.usage_after_last_gc | Measure of memory used, as measured after the most recent garbage collection event on this pool | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"nonheap"` | +| process.runtime.jvm.memory.usage_after_last_gc | Measure of memory used, as measured after the most recent garbage collection event on this pool | Bytes | `By` | UpDownCounter | Int64 | type | `"heap"`, `"non_heap"` | | | | | | | | pool | Name of pool [1] | | process.runtime.jvm.threads.count | Number of executing threads | threads | `{threads}` | UpDownCounter | Int64 | daemon | `true`, `false` | | process.runtime.jvm.classes.loaded | Number of classes loaded since JVM start | classes | `{classes}` | Counter | Int64 | | |