From e8e606674184a09bec62a629e7ee68fd497a4093 Mon Sep 17 00:00:00 2001 From: Tigran Najaryan Date: Fri, 14 Aug 2020 16:12:16 -0400 Subject: [PATCH] Address PR comments --- specification/common/common.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/specification/common/common.md b/specification/common/common.md index 4290eaaffd5..da99e84528c 100644 --- a/specification/common/common.md +++ b/specification/common/common.md @@ -56,7 +56,7 @@ Attribute names SHOULD follow these rules: words by underscores (i.e. use snake_case). For example `http.status_code` denotes the status code in the http namespace. -- Attribute names should not coincide with namespaces. For example if +- Attribute names SHOULD NOT coincide with namespaces. For example if `service.instance.id` is an attribute name then it is no longer valid to have an attribute named `service.instance` because `service.instance` is already a namespace. Because of this rule be careful when choosing attribute names: @@ -66,7 +66,7 @@ Attribute names SHOULD follow these rules: #### Recommendations for OpenTelemetry Authors -- All attributes names that are part of OpenTelemetry semantic conventions +- All attribute names that are part of OpenTelemetry semantic conventions SHOULD be part of a namespace. - When coming up with a new convention make sure to check existing namespaces