From cb4f03cfb1e019dad353d1714d0245b59d325429 Mon Sep 17 00:00:00 2001 From: mateuszrzeszutek Date: Mon, 17 Aug 2020 12:41:40 +0200 Subject: [PATCH] Rename `thread.*` attributes to `process.thread.*` --- .../semantic_conventions/span-general.md | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/specification/trace/semantic_conventions/span-general.md b/specification/trace/semantic_conventions/span-general.md index d656c358d25..ed7be5053e7 100644 --- a/specification/trace/semantic_conventions/span-general.md +++ b/specification/trace/semantic_conventions/span-general.md @@ -13,7 +13,7 @@ Particular operations may refer to or require some of these attributes. * [`net.*.name` attributes](#netname-attributes) - [General remote service attributes](#general-remote-service-attributes) - [General identity attributes](#general-identity-attributes) -- [General thread attributes](#general-thread-attributes) +- [General process attributes](#general-process-attributes) @@ -131,23 +131,25 @@ Given the sensitive nature of this information, SDKs and exporters SHOULD drop t default and then provide a configuration parameter to turn on retention for use cases where the information is required and would not violate any policies or regulations. -## General thread attributes +## General process attributes These attributes may be used for any operation to store information about -a thread that started a span. +a process. +The `process.thread.*` attributes contain information about a thread that started +a span. -| Attribute name | Notes and examples | -|----------------|---------------------------------------------------------------------| -| `thread.id` | Current "managed" thread ID (as opposed to OS thread ID). E.g. `42` | -| `thread.name` | Current thread name. E.g. `main` | +| Attribute name | Notes and examples | +|-----------------------|---------------------------------------------------------------------| +| `process.thread.id` | Current "managed" thread ID (as opposed to OS thread ID). E.g. `42` | +| `process.thread.name` | Current thread name. E.g. `main` | Examples of where `thread.id` and `thread.name` can be extracted from: -| Launguage or platform | `thread.id` | `thread.name` | +| Launguage or platform | `process.thread.id` | `process.thread.name` | |-----------------------|----------------------------------------|------------------------------------| | JVM | `Thread.currentThread().getId()` | `Thread.currentThread().getName()` | | .Net | `Thread.CurrentThread.ManagedThreadId` | `Thread.CurrentThread.Name` | | Python | `threading.current_thread().ident` | `threading.current_thread().name` | | Ruby | | `Thread.current.name` | -| C++ | `std::this_thread::get_id()` | | -| Erlang | `erlang:system_info(scheduler_id)` | | +| C++ | `std::this_thread::get_id()` | | +| Erlang | `erlang:system_info(scheduler_id)` | |