Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show working example for OTLP Http #1756

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented May 14, 2024

Fixes #1659
Based on #1752 (comment), the example for otlp-http is modified to use HTTP/protobuf instead of json.
Also modified the example to use log appenger instead of tracing appender, as tracing causes #761, and cannot be used without fixing.

@cijothomas cijothomas requested a review from a team May 14, 2024 02:22
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.6%. Comparing base (348ec9e) to head (b18a48e).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1756     +/-   ##
=======================================
+ Coverage   71.0%   71.6%   +0.5%     
=======================================
  Files        135     136      +1     
  Lines      20751   20845     +94     
=======================================
+ Hits       14746   14934    +188     
+ Misses      6005    5911     -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 4bc2d8c into open-telemetry:main May 14, 2024
20 checks passed
@TommyCpp
Copy link
Contributor

I am not sure if the provided example will help users understand how to enable hyper clients. As it uses reqwest clients

@cijothomas cijothomas deleted the cijothomas/otlp-example-proto branch May 14, 2024 03:02
@cijothomas
Copy link
Member Author

I am not sure if the provided example will help users understand how to enable hyper clients. As it uses reqwest clients

Agree. Should we fix that in the doc itself, instead of maintaining full blown examples for each transport/clients?

@ibigbug
Copy link

ibigbug commented May 20, 2024

yeah i think a doc would be super helpfule. i'm struggling updating to the latest versions with a combination of

# opentelemetry
opentelemetry = "0.23"
opentelemetry_sdk = { version = "0.23", features = ["rt-tokio"] }
tracing-opentelemetry = "0.23"
opentelemetry-jaeger-propagator = "0.2.0"
opentelemetry-jaeger = { version = "0.22", features = ["collector_client", "hyper_collector_client", "rt-tokio"] }
opentelemetry-otlp = { version = "0.16.0", features = ["http-proto"] }

also to be frank i feel the rust community library versions are a bit fragile, it sometimes require a fair bit of work to upgrade all eco system crates when 1 crate gets a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: unclear how to setup http(hyper) without agent pipeline
4 participants