Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump semantic_conventions gem to 1.10.0 #1171

Merged

Conversation

ahayworth
Copy link
Contributor

This PR bumps the semantic_conventions gem to the 1.10.0 semantic conventions release.

It's fairly uninteresting overall; but the commit messages have the full details and are replayed here for your convenience.


feat!: update for semantic conventions @ v1.10.0

The most notable thing here is that the delta between 1.8.0 and 1.10.0
results in a few fields going away. This will be a breaking change for
anyone who happens to be depending upon these fields:

  • DB_CASSANDRA_KEYSPACE
  • DB_HBASE_NAMESPACE

Users should instead use DB_NAME, according to
open-telemetry/opentelemetry-specification#1973.

Otherwise, we get the standard deal:

  • A plethora of new, exciting fields!
  • Reworded explanatory text!

Overall, not a terribly exciting change, but we must often take joy in
the small things, and I choose to do so here!


chore: bump semconvgen from 0.4.1 -> 0.11.1

I couldn't find any huge changes from the release notes; it seems the
generated wording was improved in some cases. Regardless, let us not
drift too far behind.

I couldn't find any huge changes from the release notes; it seems the
generated wording was improved in some cases. Regardless, let us not
drift too far behind.
The most notable thing here is that the delta between 1.8.0 and 1.10.0
results in a few fields going away. This will be a breaking change for
anyone who happens to be depending upon these fields:

- `DB_CASSANDRA_KEYSPACE`
- `DB_HBASE_NAMESPACE`

Users should instead use `DB_NAME`, according to
[open-telemetry/opentelemetry-specification#1973](open-telemetry/opentelemetry-specification#1973).

Otherwise, we get the standard deal:

- A plethora of new, exciting fields!
- Reworded explanatory text!

Overall, not a terribly exciting change, but we must often take joy in
the small things, and I choose to do so here!
Copy link
Contributor

@plantfansam plantfansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup!

@fbogsany fbogsany merged commit 159044d into open-telemetry:main Apr 8, 2022
@dazuma dazuma mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants