Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP status codes and errors #198

Closed
mwear opened this issue Feb 27, 2020 · 2 comments
Closed

HTTP status codes and errors #198

mwear opened this issue Feb 27, 2020 · 2 comments
Labels
question Further information is requested

Comments

@mwear
Copy link
Member

mwear commented Feb 27, 2020

Currently our HTTP instrumentation will record errors for unhandled exceptions. Should we create errors based on response codes? If so, we should do this uniformly across our instrumentation adapters. We may also want to add this to the datadog porting guide as well.
@mwear mwear added the question Further information is requested label Feb 27, 2020
@mwear mwear mentioned this issue Feb 27, 2020
Merged
@fbogsany
Copy link
Contributor

We appear to be setting status based on HTTP response codes in all of our HTTP client and server framework auto-instrumentation. Is anything else required for this issue @mwear?

@mwear
Copy link
Member Author

mwear commented Jan 12, 2021

I think we are doing the right thing. Closing...

@mwear mwear closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbogsany @mwear