Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing AWS Resource Detectors #34

Closed
NathanielRN opened this issue Jan 25, 2022 · 4 comments
Closed

Add Missing AWS Resource Detectors #34

NathanielRN opened this issue Jan 25, 2022 · 4 comments
Labels
help wanted Extra attention is needed stale Marks an issue/PR stale

Comments

@NathanielRN
Copy link
Contributor

NathanielRN commented Jan 25, 2022

Description

NOTE: We should block on #33 before addressing this issue because the Resource Detectors should go in the same opentelemetry-sdk-extension-aws gem as the ID Generator.

We should add Resource Detectors to automatically populate the resource.* attributes of all spans in certain attributes. For example, if an app is running on EC2, users should be able to use the OpenTelemetry EC2 Resource Detector to automatically populate information about the EC2 instance they are running on.

Resource Detectors already exist in several other OTel Languages:

OTel Java:

OTel Python

These languages have resource detectors, but put them in separate packages:

OTel Go:

OTel JS:

.NET has all X-Ray necessary components in one package, but should split the propagator out eventually

OTel .NET

The X-Ray team would be happy to help contribute these in the near future! 🙂

@arielvalentin arielvalentin added the help wanted Extra attention is needed label Jan 25, 2022
@khyatigandhi6
Copy link
Contributor

Hi,
I would love to help by contributing resource detectors for AWS EC2, ECS and Lambda as part of this issue.
Let me know if can raise a PR.

@NathanielRN
Copy link
Contributor Author

Thanks @khyatigandhi6! I'm sure I would be able to find people on the AWS to help review 🙂 However, we should block this issue and resolve #33 first. Would you be willing to take that issue on?

@khyatigandhi6
Copy link
Contributor

Hey @NathanielRN, Currently I don't have much knowledge and hands-on related to X-ray ID-generators. But I will have a look at it and will definitely take up that issue, if I find something around it :)

@plantfansam plantfansam transferred this issue from open-telemetry/opentelemetry-ruby Jun 14, 2022
@github-actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Apr 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed stale Marks an issue/PR stale
Projects
None yet
Development

No branches or pull requests

3 participants