-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing AWS Resource Detectors #34
Comments
Hi, |
Thanks @khyatigandhi6! I'm sure I would be able to find people on the AWS to help review 🙂 However, we should block this issue and resolve #33 first. Would you be willing to take that issue on? |
Hey @NathanielRN, Currently I don't have much knowledge and hands-on related to X-ray ID-generators. But I will have a look at it and will definitely take up that issue, if I find something around it :) |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Description
NOTE: We should block on #33 before addressing this issue because the Resource Detectors should go in the same
opentelemetry-sdk-extension-aws
gem as the ID Generator.We should add Resource Detectors to automatically populate the
resource.*
attributes of all spans in certain attributes. For example, if an app is running on EC2, users should be able to use the OpenTelemetry EC2 Resource Detector to automatically populate information about the EC2 instance they are running on.Resource Detectors already exist in several other OTel Languages:
OTel Java:
OTel Python
These languages have resource detectors, but put them in separate packages:
OTel Go:
OTel JS:
.NET has all X-Ray necessary components in one package, but should split the propagator out eventually
OTel .NET
The X-Ray team would be happy to help contribute these in the near future! 🙂
The text was updated successfully, but these errors were encountered: