Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup pylint broad exceptions warnings #3923

Merged

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented May 22, 2024

Description

Reenable pylint check for broad exceptions after fixing the current disabling comments

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 22, 2024
@xrmx xrmx self-assigned this May 22, 2024
xrmx added 2 commits May 22, 2024 11:40
The warning has been splitted into broad-exception-caught and
broad-exception-raised.
@xrmx xrmx force-pushed the fixup-pylint-broad-exceptions-warnings branch from be3acd9 to 5ae3444 Compare May 22, 2024 09:40
@xrmx xrmx marked this pull request as ready for review May 22, 2024 10:02
@xrmx xrmx requested a review from a team May 22, 2024 10:02
@xrmx xrmx removed their assignment May 22, 2024
@lzchen lzchen merged commit dbf6943 into open-telemetry:main May 24, 2024
233 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants