Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestBase assertEqualSpanInstrumentationInfo when no longer used #4301

Closed
tammy-baylis-swi opened this issue Nov 20, 2024 · 1 comment · Fixed by #4310
Closed

Remove TestBase assertEqualSpanInstrumentationInfo when no longer used #4301

tammy-baylis-swi opened this issue Nov 20, 2024 · 1 comment · Fixed by #4310
Assignees

Comments

@tammy-baylis-swi
Copy link
Contributor

tammy-baylis-swi commented Nov 20, 2024

Is your feature request related to a problem?

Yes, open-telemetry/opentelemetry-python-contrib#3033

Describe the solution you'd like

It would be nice if we could remove assertEqualSpanInstrumentationInfo because it results in deprecation warnings. See contrib issue open-telemetry/opentelemetry-python-contrib#3033

Maybe we could do this step-wise:

  1. Remove all contrib uses (Stop TestBase DeprecationWarnings from instrumentor test span info checks opentelemetry-python-contrib#3033)
  2. There doesn't seem to be any core uses (grep)
  3. For a few releases, have assertEqualSpanInstrumentationInfo log warnings that it will be removed in a future release.
  4. Remove assertEqualSpanInstrumentationInfo.

Describe alternatives you've considered

Or keep it forever?

Additional Context

n/a

Would you like to implement a fix?

Yes

@tammy-baylis-swi tammy-baylis-swi added the bug Something isn't working label Nov 20, 2024
@tammy-baylis-swi tammy-baylis-swi self-assigned this Nov 20, 2024
@tammy-baylis-swi
Copy link
Contributor Author

tammy-baylis-swi commented Nov 20, 2024

I think this should be a contrib issue instead. Closing.

Work on open-telemetry/opentelemetry-python-contrib#3033 first.

@tammy-baylis-swi tammy-baylis-swi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2024
@tammy-baylis-swi tammy-baylis-swi added feature-request and removed bug Something isn't working labels Nov 20, 2024
@tammy-baylis-swi tammy-baylis-swi changed the title Fix TestBase DeprecationWarnings Remove TestBase assertEqualSpanInstrumentationInfo when no longer used Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant