Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTEL_EXPORTER_OTLP_LOGS_* env vars #2939

Closed
srikanthccv opened this issue Sep 20, 2022 · 7 comments · Fixed by #3037
Closed

Add support for OTEL_EXPORTER_OTLP_LOGS_* env vars #2939

srikanthccv opened this issue Sep 20, 2022 · 7 comments · Fixed by #3037

Comments

@srikanthccv
Copy link
Member

Similar to traces and metrics, the OTLP metric exporter should support OTEL_EXPORTER_OTLP_LOGS_* env vars.

Exporter protocol specification https://github.com/open-telemetry/opentelemetry-specification/blob/ab70eb9d364e7d6f25ba45e4ccbebaadceb5fa6a/specification/protocol/exporter.md

@sudhanshu-chauhan
Copy link

would like to take this up @srikanthccv

@srikanthccv
Copy link
Member Author

@sudhanshu-chauhan are you still working on this?

@srikanthccv
Copy link
Member Author

@sudhanshu-chauhan Since there has been no progress for the last 45 days, and you haven't responded, I assume you don't have the time to complete it. I am unassigning you. If you want to pick up something again, there is always more to do.

@pridhi-arora
Copy link
Contributor

pridhi-arora commented Nov 15, 2022

@srikanthccv Can I take this one up?

@pridhi-arora
Copy link
Contributor

pridhi-arora commented Nov 15, 2022

Similar to traces and metrics, the OTLP metric exporter should support Does it intend to say OTLP log exporter?
Traces, metrics, and logs are the 3 metrics, as I understand by working on my previous PR.

@srikanthccv
Copy link
Member Author

Does it intend to say OTLP log exporter?

You correct. They are already supported for traces and metrics. This issue is for adding the same to the OTLP log exporter. We need to add support in two places

  1. gRPC exporter (https://github.com/open-telemetry/opentelemetry-python/tree/main/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_log_exporter)
  2. HTTP exporter (https://github.com/open-telemetry/opentelemetry-python/tree/main/exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter)

Look at how OTEL_EXPORTER_OTLP_TRACES_* or OTEL_EXPORTER_OTLP_METRICS_* are implemented and do the same. Let me know if you need any other help.

@pridhi-arora
Copy link
Contributor

Thanks @srikanthccv Taking this one up first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants