Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC integration #276

Closed
c24t opened this issue Nov 7, 2019 · 5 comments
Closed

Add gRPC integration #276

c24t opened this issue Nov 7, 2019 · 5 comments
Assignees
Milestone

Comments

@c24t
Copy link
Member

c24t commented Nov 7, 2019

Add a gRPC integration in the style of opencensus-ext-grpc, using gRPC python interceptors.

@c24t c24t added the ext label Nov 7, 2019
@codeboten
Copy link
Contributor

The opentelemetry-auto-instr-python repo contains an integration for gRPC. We could port that into this repo.

@kapilt
Copy link

kapilt commented Nov 28, 2019

one request, please have a care for those that find grpc unwieldy as a large binary dependency, or complicated in its runtime usage analysis (considerable complexity in its implementation, background threads, locks), and make it optional instead of a require dependency of the opentelemetry sdk.

[update] i see all integrations are cleanly separated out into the ext packages, so above shouldn't be a concern.

@hectorhdzg
Copy link
Member

@codeboten codeboten mentioned this issue Feb 13, 2020
34 tasks
@c24t c24t self-assigned this Feb 20, 2020
@toumorokoshi toumorokoshi added this to the Beta milestone Feb 27, 2020
@andrewhsu
Copy link
Member

Looks like related PR: #476

@c24t c24t modified the milestones: Beta, 3/31 Beta Mar 18, 2020
@c24t
Copy link
Member Author

c24t commented Mar 31, 2020

Fixed by #476.

@c24t c24t closed this as completed Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants