Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow of configuration of Sampler in auto-instrumentation #2746

Closed
lzchen opened this issue Jun 7, 2022 · 2 comments · Fixed by #2972
Closed

Allow of configuration of Sampler in auto-instrumentation #2746

lzchen opened this issue Jun 7, 2022 · 2 comments · Fixed by #2972
Labels
auto-instrumentation related to auto-instrumentation of the sdk feature-request good first issue Good first issue

Comments

@lzchen
Copy link
Contributor

lzchen commented Jun 7, 2022

Similar to id generator, allow for custom samplers to be configured as part of autoinstrumentation.
@lzchen lzchen added auto-instrumentation related to auto-instrumentation of the sdk feature-request good first issue Good first issue labels Jun 7, 2022
@srikanthccv
Copy link
Member

srikanthccv commented Jun 7, 2022 •
edited
Loading

Did you mean providing them with entrypoint style? One could configure the SDK samplers with env today.

@lzchen
Copy link
Contributor Author

lzchen commented Jun 7, 2022

Yes entrypoint style. I don't believe someone can configure a custom sampler with an env var.

@jeremydvoss jeremydvoss mentioned this issue Oct 10, 2022
Merged
19 tasks
@jeremydvoss jeremydvoss mentioned this issue May 16, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-instrumentation related to auto-instrumentation of the sdk feature-request good first issue Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabled custom sampler configuration via env vars jeremydvoss/opentelemetry-python
2 participants
@lzchen @srikanthccv