Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics SDK checks into API #2324

Closed
ocelotl opened this issue Dec 14, 2021 · 3 comments
Closed

Move metrics SDK checks into API #2324

ocelotl opened this issue Dec 14, 2021 · 3 comments
Labels

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Dec 14, 2021

Opening an issue to track this with the intention of being able to merge #2297 into main.

Curious as to why this behavior is defined in the sdk and not the api? Shouldn't all implementations of counter.add not take in negative increments?

Originally posted by @lzchen in #2297 (comment)

@ocelotl
Copy link
Contributor Author

ocelotl commented Dec 15, 2021

I do agree with moving these checks from the SDK into the API. I can take this issue, but before that, I think this has not been discussed much yet. Does anyone prefer we take another approach?

@aabmass @lzchen @lonewolf3739

@lzchen
Copy link
Contributor

lzchen commented Jan 3, 2022

@ocelotl
I suggest we bring this up during the next SIG meeting. Feel free to add this issue to the list of topics.

@lzchen
Copy link
Contributor

lzchen commented Jan 11, 2022

From 1/11 meeting, we have decided to leave the checks in the metrics sdk.

@lzchen lzchen closed this as completed Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants