Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a few remaining checks for python3.4 #1321

Closed
aabmass opened this issue Nov 2, 2020 · 0 comments · Fixed by #1326
Closed

Remove a few remaining checks for python3.4 #1321

aabmass opened this issue Nov 2, 2020 · 0 comments · Fixed by #1326
Assignees
@aabmass

Comments

@aabmass
Copy link
Member

aabmass commented Nov 2, 2020 •
edited
Loading

Some of the setup.py files still have python_version<'3.5' checks, which are no longer necessary: https://github.com/open-telemetry/opentelemetry-python/search?q=python_version%3C%273.5%27

We also don't need comment style annotations anymore (# type: Optional[Foo]) these are also unsupported in python3.5 :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove remaining checks in setup.py files for python3.4 aabmass/opentelemetry-python
1 participant
@aabmass