Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow samplers to modify tracestate #1220

Closed
codeboten opened this issue Oct 8, 2020 · 0 comments · Fixed by #1319
Closed

Allow samplers to modify tracestate #1220

codeboten opened this issue Oct 8, 2020 · 0 comments · Fixed by #1319
Assignees
@lzchen
Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per spec change: open-telemetry/opentelemetry-specification#988
@codeboten codeboten added good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release labels Oct 8, 2020
@lzchen lzchen self-assigned this Oct 21, 2020
@codeboten codeboten added the rc1 label Oct 29, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@markwolff @mayurkale22
refactor: deprecate attribute.component (open-telemetry#1220)
806eabd 
* refactor: deprecate attribute.component

* fix(tests): shift test attribute indexes

Co-authored-by: Naseem <[email protected]>
Co-authored-by: Mayur Kale <[email protected]>
@lzchen lzchen mentioned this issue Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow samplers to modify TraceState lzchen/opentelemetry-python
2 participants
@codeboten @lzchen