Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit statefulness in OTLP MetricExporter #1007

Closed
codeboten opened this issue Aug 18, 2020 · 1 comment
Closed

Revisit statefulness in OTLP MetricExporter #1007

codeboten opened this issue Aug 18, 2020 · 1 comment
Assignees
@ocelotl
Labels
1.10.0rc1 release candidate 1 for metrics GA exporters metrics release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

As per the discussion here: #835 (comment)

The OTLP MetricExporter will need to be revisited as the metrics SDK, protos and spec evolve.
@codeboten codeboten added metrics exporters release:required-for-ga To be resolved before GA release labels Aug 18, 2020
@ocelotl ocelotl self-assigned this Oct 19, 2020
@aabmass aabmass mentioned this issue Nov 17, 2020
Closed
@jmacd
Copy link

jmacd commented Nov 18, 2020

This "stateless" concept is discussed in open-telemetry/opentelemetry-specification#1198. The concept found in this code predates the current OTel-Go design, which changed after I found design errors in the Prometheus export path. The SDK spec PR 1198 talks about two behaviors that cause statefulness to arise: (1) conversion from delta to cumulative for the counter instruments, (2) memory simply for the same of memory. Both of these are needed for Prometheus, which expects you to continue exporting the last sample of all timeseries that were ever exported from the process.

@codeboten codeboten added the 1.10.0rc1 release candidate 1 for metrics GA label Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.10.0rc1 release candidate 1 for metrics GA exporters metrics release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @jmacd @ocelotl