We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe your environment Seeing this exhibited in Pyramid 1.10 and as far back as Pyramid 1.7.
Steps to reproduce Raise a non-HTTPException.
What is the expected behavior? Tweens should process normally.
What is the actual behavior? An error for use of response_or_exception before assignment is raised.
response_or_exception
Additional context The problem exists here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py#L146-L157. It seems there should be an additional exception case for BaseException to initialize response_or_exception.
BaseException
The text was updated successfully, but these errors were encountered:
Proposed fix makes sense. PRs welcome :)
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe your environment
Seeing this exhibited in Pyramid 1.10 and as far back as Pyramid 1.7.
Steps to reproduce
Raise a non-HTTPException.
What is the expected behavior?
Tweens should process normally.
What is the actual behavior?
An error for use of
response_or_exception
before assignment is raised.Additional context
The problem exists here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-pyramid/src/opentelemetry/instrumentation/pyramid/callbacks.py#L146-L157. It seems there should be an additional exception case for
BaseException
to initializeresponse_or_exception
.The text was updated successfully, but these errors were encountered: