Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit_bucket_boundaries_advisory to new semconv duration histograms for HTTP instrumentations #3220

Open
8 tasks
emdneto opened this issue Jan 30, 2025 · 0 comments

Comments

@emdneto
Copy link
Member

emdneto commented Jan 30, 2025

At this moment, we have an issue with all instrumentation that supports duration metrics based on the stable semantic convention. When using the stable semantic convention opt-in feature, duration histogram data points are recorded in seconds, but histogram buckets are still defined in ms, which leads to a wrong calculation and presentation of percentiles.

The plan is: with the merge of open-telemetry/opentelemetry-python#4361, we can move forward and add the advisory explicit_bucket_boundaries_advisory parameter for duration histograms of already migrated HTTP instrumentation that uses the stable semantic convention.

explicit_bucket_boundaries_advisory = [0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10]

HTTP_SERVER_REQUEST_DURATION
HTTP_CLIENT_REQUEST_DURATION

Instrumentations

  • opentelemetry-instrumentation-flask
  • opentelemetry-instrumentation-django
  • opentelemetry-instrumentation-falcon
  • opentelemetry-instrumentation-wsgi
  • opentelemetry-instrumentation-asgi
  • opentelemetry-instrumentation-urllib
  • opentelemetry-instrumentation-urllib3
  • opentelemetry-instrumentation-requests

Related issues:

@emdneto emdneto changed the title Add explicit_bucket_boundaries_advisory to new semconv duration histograms HTTP instrumentations Add explicit_bucket_boundaries_advisory to new semconv duration histograms for HTTP instrumentations Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant