Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASGI, FastAPI, Starlette: provide both send and receive hooks with scope and message #2560

Closed
eigenein opened this issue May 28, 2024 · 0 comments · Fixed by #2546
Closed
Assignees

Comments

@eigenein
Copy link
Contributor

Is your feature request related to a problem?

Currently, a «receive» hook is only provided with scope, but not message. On contrary, a «send» hook is only provided with message, but not scope. In particular, it makes it impossible for a receive hook to inspect events.

Describe the solution you'd like

Unify both hooks so that they both would accept the both parameters.

Additional context

The feature request is already implemented in this PR: #2546

This is going to be a breaking change, since the hooks will accept additional parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant