Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Lambda event source key incorrect for SNS in instrumentation library. #2511

Closed
mau-alex-ruiz opened this issue May 9, 2024 · 2 comments · Fixed by #2612 · May be fixed by #2585
Closed

AWS Lambda event source key incorrect for SNS in instrumentation library. #2511

mau-alex-ruiz opened this issue May 9, 2024 · 2 comments · Fixed by #2612 · May be fixed by #2585
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mau-alex-ruiz
Copy link

Description
This line is checking for the key eventSource which will never be satisfied for SNS. Per AWS docs, the key is actually EventSource. The very simple fix would be to simply check for both eventSource and EventSource.

What is the expected behavior?
What did you expect to see?
span_kind for SNS event sources should be set to CONSUMER

What is the actual behavior?
span_kind for SNS event sources are being set to SERVER
@mau-alex-ruiz mau-alex-ruiz added the bug Something isn't working label May 9, 2024
@xrmx xrmx added the good first issue Good for newcomers label Jun 13, 2024
@zhihali
Copy link
Contributor

zhihali commented Jun 13, 2024

Hi, Can I pick this one?

@emdneto
Copy link
Member

emdneto commented Jun 13, 2024

@Charlie-lizhihan Please, feel free to open a PR!

@zhihali zhihali mentioned this issue Jun 15, 2024
Merged
6 tasks
@jbfenton jbfenton mentioned this issue Jun 16, 2024
Draft
7 tasks
@zhihali zhihali mentioned this issue Jul 16, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@xrmx @emdneto @mau-alex-ruiz @zhihali